This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Avoid rate GH rate limit when adding chains from registry #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
suggested changes
Oct 13, 2022
agouin
pushed a commit
that referenced
this pull request
Dec 12, 2022
* avoid rate gh rate limit * close response and improve readability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we use the github client to pull data down from the chain-registry, it is easy to hit the github rate limit when adding many chains to your config.
Instead of using the github client, this PR "GETS" the raw json from the chain-registry.
It also cleans up the log out put.
Note: Lens will still use the github client when using the
lens chains registry-listcommand