Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: add vendor-filter metadata #3409

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

bgurney-rh
Copy link
Member

@bgurney-rh bgurney-rh commented Aug 15, 2023

@bgurney-rh bgurney-rh self-assigned this Aug 15, 2023
@bgurney-rh
Copy link
Member Author

Amending all-features = true to ensure that pretty-hex is included

@mulkieran mulkieran marked this pull request as ready for review August 15, 2023 21:57
@mulkieran
Copy link
Member

mulkieran commented Aug 15, 2023

The * configuration works, but I encountered an error:

Gathering metadata for platforms
error: Executing cargo metadata: Error during execution of `cargo metadata`: error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --target m68k-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
  --- stderr
  error: could not create LLVM TargetMachine for triple: m68k-unknown-linux-gnu: No available targets are compatible with triple "m68k-unknown-linux-gnu"

The associated issue is: coreos/cargo-vendor-filterer#50 .

We could consider filtering by tier.

Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tier = "2" so this will build with Fedora Rust release, and we can consider this ready to merge.

@bgurney-rh
Copy link
Member Author

Amended tier = "2"

Signed-off-by: Bryan Gurney <bgurney@redhat.com>
@mulkieran mulkieran merged commit 1982875 into stratis-storage:master Aug 16, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants