add HMap.mapValues #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 82.66% 82.71% +0.04%
==========================================
Files 13 13
Lines 375 376 +1
Branches 20 20
==========================================
+ Hits 310 311 +1
Misses 65 65
Continue to review full report at Codecov.
|
johnynek
approved these changes
Mar 9, 2019
johnynek
requested changes
Mar 9, 2019
| @@ -81,6 +81,9 @@ final class HMap[K[_], V[_]](protected val map: Map[K[_], V[_]]) extends Seriali | |||
| val fnAny = f.toFunction[Any].andThen(_.iterator) | |||
| map.iterator.asInstanceOf[Iterator[(K[Any], V[Any])]].flatMap(fnAny).toStream | |||
| } | |||
|
|
|||
| def mapValues[V1[_]](f: FunctionK[V, V1]): HMap[K, V1] = | |||
| HMap.from[K, V1](map.mapValues(f(_))) | |||
There was a problem hiding this comment.
Actually one request, mapValues is lazy on maps and this often burns people. Can we make this strict? map.iterator.map { case (k, v.... or something?
johnynek
approved these changes
Mar 9, 2019
|
Thanks! |
|
Oh, it looks like git can’t tell this is independent of your previous PR and there is a merge conflict. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #39