Add Dag.applySeq for sequential rule application #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non
reviewed
Sep 7, 2017
| * Apply a sequence of rules in order | ||
| * First apply one rule until it does not apply, then the next, etc.. | ||
| */ | ||
| def applySeq(rules: Seq[Rule[N]]): Dag[N] = |
There was a problem hiding this comment.
want to call these phases instead of rules to sort of hint at the ordering part?
non
reviewed
Sep 7, 2017
| /** | ||
| * If the current rule cannot apply, then try the argument here | ||
| * Note, this applies in series at a given node, not on the whole | ||
| * Dag after the first rule has run. For that, see Dag.applySeq |
|
Modulo naming/grammar this is great. 👍 |
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 86.09% 86.24% +0.14%
==========================================
Files 12 12
Lines 187 189 +2
Branches 13 15 +2
==========================================
+ Hits 161 163 +2
Misses 26 26
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.