Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AF_* definitions and AF_XDP header and structs to v0.4.11 #98

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

arctic-alpaca
Copy link
Contributor

Adds required definitions, and structs for bytecodealliance/rustix#941

@sunfishcode
Copy link
Owner

With the update to a newer Linux version, some of the io_uring struct fields are renamed, and it ends up being semver-incompatible. Consequently, we won't be able to land that change on the 0.4 branch.

And unfortunately, rustix 0.38 publicly depends on linux-raw-sys 0.4.

One option here would be to add just the new types and macros you need to gen/modules/*.h, rather than updating the whole crate to Linux 6.6. Would that work here?

@arctic-alpaca
Copy link
Contributor Author

I removed the version change and included the two definitions added in kernel version 6.6 with a comment to remove them once the crate hits kernel version 6.6.

@sunfishcode
Copy link
Owner

This is still marked as a draft; is this ready for review now?

@arctic-alpaca
Copy link
Contributor Author

It is ready for review. I initially created this as draft as I wasn't sure whether you were interested in adding AF_XDP related syscalls to rustix (bytecodealliance/rustix#941).

@arctic-alpaca arctic-alpaca marked this pull request as ready for review November 30, 2023 16:52
@sunfishcode
Copy link
Owner

Sounds good.

@sunfishcode sunfishcode merged commit 20f094f into sunfishcode:0.4 Nov 30, 2023
5 checks passed
sunfishcode pushed a commit that referenced this pull request Nov 30, 2023
…11 (#98)

* Add missing `AF_*` definitions

* Add AF_XDP header and structs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants