Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for vanity subdomains #677

Merged
merged 1 commit into from
Dec 9, 2022
Merged

feat: adds support for vanity subdomains #677

merged 1 commit into from
Dec 9, 2022

Conversation

darora
Copy link
Contributor

@darora darora commented Dec 8, 2022

No description provided.

@darora darora requested a review from a team as a code owner December 8, 2022 04:49
sweatybridge
sweatybridge approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest lgtm

@darora @sweatybridge
feat: adds support for vanity subdomains
76fbeee 
Co-authored-by: Han Qiao <sweatybridge@gmail.com>
@coveralls
Copy link

coveralls commented Dec 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3654454528

  • 11 of 142 (7.75%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 56.228%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/vanity_subdomains/delete/delete.go 0 23 0.0%
internal/vanity_subdomains/check/check.go 0 26 0.0%
internal/vanity_subdomains/get/get.go 0 26 0.0%
cmd/vanitySubdomains.go 11 38 28.95%
internal/vanity_subdomains/activate/activate.go 0 29 0.0%
Totals Coverage Status
Change from base Build 3645703926: -1.2%
Covered Lines: 3354
Relevant Lines: 5965
💛 - Coveralls

@darora darora merged commit d7150ef into main Dec 9, 2022
@darora darora deleted the da/vanity-subdomains branch December 9, 2022 04:35
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darora @coveralls @sweatybridge