Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/an error when tried to run the rake task no method error undefined method file contents for nil nil class cu 86b1zgdgq #2

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

muzsuvie
Copy link

@muzsuvie muzsuvie commented Sep 9, 2024

No description provided.

@muzsuvie muzsuvie force-pushed the feature/An-error-when-tried-to-run-the-rake-task-NoMethodError-undefined-method-file_contents-for-nilNilClass_CU-86b1zgdgq branch from c2ddca3 to 2097d9d Compare September 9, 2024 19:43
Copy link
Member

@NewAlexandria NewAlexandria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of nice work in here, but I think it needs a bit of cleanup

app/models/rake_ui/rake_task_log.rb Show resolved Hide resolved
README.md Show resolved Hide resolved
app/controllers/rake_ui/rake_task_logs_controller.rb Outdated Show resolved Hide resolved
@muzsuvie muzsuvie force-pushed the feature/An-error-when-tried-to-run-the-rake-task-NoMethodError-undefined-method-file_contents-for-nilNilClass_CU-86b1zgdgq branch 2 times, most recently from 2556eff to 9d99e47 Compare September 10, 2024 13:18
@muzsuvie muzsuvie changed the base branch from master to config-custom-auth September 13, 2024 14:52
@muzsuvie muzsuvie force-pushed the feature/An-error-when-tried-to-run-the-rake-task-NoMethodError-undefined-method-file_contents-for-nilNilClass_CU-86b1zgdgq branch from 2264f77 to 712c833 Compare September 13, 2024 18:07
@muzsuvie muzsuvie force-pushed the feature/An-error-when-tried-to-run-the-rake-task-NoMethodError-undefined-method-file_contents-for-nilNilClass_CU-86b1zgdgq branch from 0bb9d25 to 90f67f3 Compare September 13, 2024 18:12
@muzsuvie muzsuvie changed the base branch from config-custom-auth to master September 13, 2024 21:02
Copy link
Member

@NewAlexandria NewAlexandria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of merging this, I might (or you can, if you have time)

  1. merge this to master without the other PR's commits (or revert them)
  2. rebase that other branch off the new master
  3. point SC API back at the other pundit WIP branch

The reason is that your PR could cleanly be opened as a PR back to the rake-ui maintainers. They might merge it and make it part of the main. But the Pundit PR is not yet ready for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants