ensure safe string return from xml method #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason, the XML builder started to append tags even for
to_s
andinspect
calls. Our code didn't call these, so it was either a rails implicit expression, or sentry inspection, or both.This built up a queue of ~116 unfinished syncs
I have created a new logtrail alert to slack, when these are failing
After merging this PR is needs to be built and merged to SC API, then released to main