Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmark suite #407

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Improve benchmark suite #407

merged 4 commits into from
Jun 29, 2022

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented Jun 29, 2022

No description provided.

@dralley dralley changed the title Add new macrobenchmarks Improve benchmark suite Jun 29, 2022
@dralley dralley force-pushed the benchmarks branch 6 times, most recently from b22caee to d9abcb8 Compare June 29, 2022 04:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #407 (f2afd0b) into master (f6d5e99) will decrease coverage by 8.48%.
The diff coverage is 97.09%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   63.84%   55.35%   -8.49%     
==========================================
  Files          20       22       +2     
  Lines       10870    13863    +2993     
==========================================
+ Hits         6940     7674     +734     
- Misses       3930     6189    +2259     
Flag Coverage Δ
unittests 55.35% <97.09%> (-8.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
benches/microbenches.rs 96.26% <96.26%> (ø)
benches/macrobenches.rs 100.00% <100.00%> (ø)
src/writer.rs 49.01% <0.00%> (-41.36%) ⬇️
src/reader.rs 63.46% <0.00%> (-25.54%) ⬇️
src/utils.rs 66.95% <0.00%> (-14.96%) ⬇️
src/errors.rs 1.73% <0.00%> (-7.80%) ⬇️
src/escapei.rs 13.96% <0.00%> (+0.05%) ⬆️
src/lib.rs 22.63% <0.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d5e99...f2afd0b. Read the comment docs.

benches/macrobenches.rs Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot some minor nits, but it is good enough. Feel free to merge it as is

.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
benches/macrobenches.rs Outdated Show resolved Hide resolved
benches/macrobenches.rs Show resolved Hide resolved
benches/microbenches.rs Outdated Show resolved Hide resolved
@dralley
Copy link
Collaborator Author

dralley commented Jun 29, 2022

Changed:

  • Added a changelog entry
  • Split the cargo fmt off into a separate lint CI job that runs once
  • Reverted the bench compare stuff and the change to that one benchmark that wasn't needed
  • Removed code coverage tracking from cargo test --benches since it would be a bit misleading
  • Added a README describing (some of) the documents in /tests/documents/

@dralley dralley merged commit 0febc2b into tafia:master Jun 29, 2022
@dralley dralley deleted the benchmarks branch June 29, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants