Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics when method that requires CAS is unavailable using #[diagnostic::on_unimplemented] #181

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Sep 17, 2024

Closes #180

See #180 for details.

Before:
before

After:
after

@taiki-e taiki-e changed the title Add #[diagnostic::on_unimplemented] based trick for targets that don't support CAS Improve diagnostics when method that requires CAS is unavailable Sep 17, 2024
@taiki-e taiki-e force-pushed the diagnostic branch 3 times, most recently from 3b63f34 to 25663f9 Compare September 18, 2024 01:34
@taiki-e taiki-e changed the title Improve diagnostics when method that requires CAS is unavailable Improve diagnostics when method that requires CAS is unavailable using #[diagnostic::on_unimplemented] Sep 18, 2024
@taiki-e taiki-e merged commit 815ff0c into main Sep 18, 2024
105 checks passed
@taiki-e taiki-e deleted the diagnostic branch September 18, 2024 14:39
@brodycj
Copy link
Sponsor

brodycj commented Sep 20, 2024

Hey Taiki E. I know you must be really busy, is there anything we can do to help get updates like this published in the near future?

I can see from your status that you are really busy, that is one reason I did not do the classic @ mention, just wanted to check in on these updates.

And many thanks for all of your hard work maintaining the crates!

@taiki-e
Copy link
Owner Author

taiki-e commented Sep 20, 2024

Published in 1.8.0.

@brodycj
Copy link
Sponsor

brodycj commented Sep 22, 2024

Thanks Taiki-E!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve diagnostics when method that requires CAS is unavailable using #[diagnostic::on_unimplemented]
2 participants