Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pedantic lints #213

Merged
merged 4 commits into from
May 17, 2024
Merged

chore: pedantic lints #213

merged 4 commits into from
May 17, 2024

Conversation

petarvujovic98
Copy link
Contributor

Fix some clippy pedantic lints and make clippy CI job fail on warnings

@petarvujovic98 petarvujovic98 changed the title chore: Pedantic lints chore: pedantic lints May 16, 2024
Brechtpd
Brechtpd approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Except the one comment, I think I would prefer the old way to be kept, but not sure if anyone else has a strong opinion for doing it the match way.

lib/src/utils.rs Outdated Show resolved Hide resolved
@petarvujovic98 petarvujovic98 added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 57d7fa6 May 17, 2024
7 of 12 checks passed
@petarvujovic98 petarvujovic98 deleted the pedantic-lints branch May 17, 2024 09:55
@Brechtpd Brechtpd mentioned this pull request May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petarvujovic98 @Brechtpd