Eliminate irrelevant rules when applying variants #12113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding utilities or components with a top-level at-rule we capture that entire object as the relevant thing for each of the candidates. We then do selector and rule elimination after the fact — especially as it relates to applying variants.
Take the HTML:
And this plugin:
With this we would look at
.outer
and eliminate any selectors that do not contain.w-full
— which is all of them. This meant that we would try to output a rule without a selector. Oops.Instead, we should eliminate any selectors that are not applicable and then, if the list becomes empty, eliminate that rule entirely.
Fixes #12111