-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move forced-colors variant after dark variant #12582
Merged
adamwathan
merged 1 commit into
tailwindlabs:master
from
lukewarlow:forced-colors-order
Dec 13, 2023
Merged
Move forced-colors variant after dark variant #12582
adamwathan
merged 1 commit into
tailwindlabs:master
from
lukewarlow:forced-colors-order
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add test for the order of the forced-colors variant
Thank you sir! |
thecrypticace
pushed a commit
that referenced
this pull request
Dec 13, 2023
Also add test for the order of the forced-colors variant
thecrypticace
pushed a commit
that referenced
this pull request
Dec 18, 2023
Also add test for the order of the forced-colors variant
thecrypticace
pushed a commit
that referenced
this pull request
Dec 18, 2023
Also add test for the order of the forced-colors variant
18 tasks
This was referenced May 19, 2024
This was referenced Jul 27, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add test for the order of the forced-colors variant
See #11694 (comment) for @devongovett's comment explaining the issue.
This would make forced-colors not match others such as contrast which should also arguably come after dark?
Just making this so it's here if you want.