-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve glob handling for folders with (
, )
, [
or ]
in the file path
#12715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
changed the title
Improve glob handling for folders with
Improve glob handling for folders with Jan 5, 2024
(
, )
, [
or ]
in the file pat(
, )
, [
or ]
in the file path
RobinMalfait
force-pushed
the
fix/issue-12708
branch
from
January 5, 2024 16:05
d7052a0
to
426904f
Compare
This was referenced Jan 5, 2024
KrisBraun
pushed a commit
that referenced
this pull request
Feb 23, 2024
…le path (#12715) * sync package-lock.json * modify `normalizePath` to keep `\\[`, `\\]`, `\\(` and `\\)` into account * manually escape () and [] characters in globs * update changelog
KrisBraun
pushed a commit
that referenced
this pull request
Feb 23, 2024
…le path (#12715) * sync package-lock.json * modify `normalizePath` to keep `\\[`, `\\]`, `\\(` and `\\)` into account * manually escape () and [] characters in globs * update changelog
thecrypticace
added a commit
that referenced
this pull request
Mar 27, 2024
This was referenced May 19, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where we assumed that
(
,)
,[
and]
were already properly escaped. This wasn't the case, let's fix it.This is also going to be a nice DX improvement for people using file based routers where the files and folders can contain any of the following characters:
()[]
In this PR, we will make sure to escape those characters, and we will also ensure that we don't double escape them if you already escaped them yourselfs. This means that the following 2 snippets will be equivalent:
Fixes: #12708