Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify config helpers into single object #5382

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Conversation

reinink
Copy link
Member

@reinink reinink commented Sep 3, 2021

This PR makes it possible to destructure all the config helpers from the first parameter so that you don't need to have an unused theme parameter just to access the second parameter.

- colors: (theme, { colors }) => ({ colors })
+ colors: ({ theme, colors }) => ({ colors })

This is not a breaking change, and theme is still accessible on its own as the first parameter (both examples above still work). However moving forward we will only document the second option.

Co-Authored-By: Adam Wathan <4323180+adamwathan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant