Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #500: handle athena map data type #503

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix #500: handle athena map data type #503

merged 2 commits into from
Oct 20, 2023

Conversation

benjamin-awd
Copy link
Contributor

No description provided.

@benjamin-awd benjamin-awd mentioned this pull request Oct 17, 2023
Closed
tconbeer
tconbeer approved these changes Oct 17, 2023
View reviewed changes
Copy link
Owner

@tconbeer tconbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very well done! Thanks so much for this. Just missing a changelog entry but I'm happy to add that for you tomorrow

@tconbeer
Copy link
Owner

(The code coverage check will fail because of credentials but you added the tests I would have)

@tconbeer tconbeer linked an issue Oct 20, 2023 that may be closed by this pull request
Strange formatting for Athena SQL array/map types #500
Closed
@tconbeer tconbeer merged commit c2c5fc7 into tconbeer:main Oct 20, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tconbeer tconbeer tconbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange formatting for Athena SQL array/map types
2 participants
@benjamin-awd @tconbeer