Add support for looking up AMIs with the EC2 API

[zl4bv]

Addresses #147. When a hash of filters are provided for the image_id it will try to find the AMI with the most recent creation date that matches the supplied filters.

Example usage (.kitchen.yml):

platforms:
  - name: windows2012r2
    driver:
      image_id:
        name: Windows_Server-2012-R2_RTM-English-64Bit-Base-*

Example usage (amis.json):

{
  "regions": {
    "ap-southeast-2": {
      "windows-2012r2": {
        "name": "Windows_Server-2012-R2_RTM-English-64Bit-Base-*"
      }
    }
  }
}

[willejs]

Is there an update on this? Would love to see it merged!

[puckel]

Hi,

👍 for this PR, it'll be very useful. Maybe add an environment variable for image_id too.

Thanks

[zl4bv]

Hey @puckel, if you want to set the image_id with an environment variable then you can add something like the following to your .kitchen.yml file:

platforms:
  - name: blah
    driver:
      image_id: "<%= ENV['IMAGE_ID'] %>"

where the environment variable IMAGE_ID has your desired AMI ID. This will work without the pull request.

[tjnicholas]

@tyler-ball any estimate when this might get merged and/or released? It looks like it'll address several open issues. #174 #117 #147

[tyler-ball]

Sorry this got dropped. The code and tests look good, but I see a few missing features to add before this can be merged.

First, while it is nice to use an existing key I think that will be confusing in the long run. Instead of overloading image_id to take either a string or a hash I think we should just introduce a new config key. Call it image_search and have it take in a hash. If both image_id and image_search are provided then give image_id precedence. Because image_id is currently defaulted you will need to move the defaulting into the finalize_config method. It will look something like

if config[:image_id].nil? && config[:image_search].nil?
  config[:image_id] = instance.driver.default_ami
end

Second, this PR needs to also update the README to outline how to leverage this new logic.

We should leave the existing amis.json logic alone but I think that is another issue we could address in the 1.0 update. Ideally, I would like to get rid of it and use a default image of the latest ubuntu image (using the search tool here). But that should be another PR. My time has been prioritized off of Test Kitchen so if anyone wants to submit that PR I would be happy to review and merge it.

[willejs]

@zl4bv do you think your going to get round to fixing this with tylers comments?

[zl4bv]

@willejs sorry, yes, I will try to get it done some time this week.

[zl4bv]

Hey @tyler-ball (and other collaborators), I've made the suggested changes. Do you think it is ready to be merged now?

[willejs]

YES! Can you cut a release please @tyler-ball

[puckel]

Hi,
When the next release is planned?
Thanks

[willejs]

new release FTW!