propagate tags to volumes #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Volume tagging would be nice to have. Any updates on when/if this will be merged? |
|
LGTM and if we can get another reviewer then we'll get this in for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propagates tags to volumes.
Similar to the instance being created before it's usable, volumes may not be available to the instance immediately.
Through some trial and error I found
ec2.client.describe_volumesto consistently return what volumes should be attached to the instance before enumerating them through the instance itself (server.volumes).wait_until_volumes_readymimicswait_until_readywhile comparing what the client can enumerate about the instance's volumes to the instance itself. Once they agree -- proceed and tag the volumes.