Add support for Windows Server 2022 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdwyertech
commented
Oct 9, 2021
| @@ -134,7 +134,7 @@ def windows_version_parts | |||
|
|
|||
| def windows_name_filter # rubocop:disable Metrics/MethodLength | |||
| major, revision, service_pack = windows_version_parts | |||
| if major == 2019 || major == 2016 | |||
| if major == 2022 || major == 2019 || major == 2016 | |||
| "Windows_Server-#{major}-English-Full-Base-*" | |||
| elsif major == 1709 || major == 1803 | |||
There was a problem hiding this comment.
This stuff can probably go -- 1709 and 1803 are no longer available as builds and the core structure follows same convention as GUI now
Signed-off-by: Brian Dwyer <brian.dwyer@broadridge.com>
|
@bdwyertech If you want to cleanup this logic for the modern era that'd be great. I'd love to never have to update this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Windows Server 2022
https://aws.amazon.com/about-aws/whats-new/2021/09/aws-microsoft-windows-server-2022-amazon-ec2/
Issues Resolved
N/A I dont think
Check List