Make deployment name an optional parameter. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate Unique naming convention issue. This change will help in getting VM name as 'Deployment + DeploymentID' Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
Bumped version for " - Eliminate Unique naming convention issue. This change will help in getting VM name as 'Deployment + DeploymentID'" Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
This update will help in getting VM name as 'Deployment + DeploymentID' Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
removed commented line to pass chefstyle Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
|
@Rupesh0688 thanks for creating the PR. A suggestion, can we make the parameter optional? i.e. it is part of the request payload if non-nil 'name' is supplied and omitted otherwise? This will help folks specify deploymentName when they need to do so via kitchen-vra plugin or another consumer of this gem. |
|
I am working on getting the requirement as accordingly |
…ed VM via test-kitchen Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
Signed-off-by: Rupesh0688 <134281322+Rupesh0688@users.noreply.github.com>
This will be updated with a separate version bump commit. Signed-off-by: Vikram Karve <vikram.karve@progress.com> Signed-off-by: Vikram Karve <85881329+vkarve-chef@users.noreply.github.com>
This will be updated with a separate version bump commit. Signed-off-by: Vikram Karve <vikram.karve@progress.com> Signed-off-by: Vikram Karve <85881329+vkarve-chef@users.noreply.github.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com> Signed-off-by: Vikram Karve <85881329+vkarve-chef@users.noreply.github.com>
Signed-off-by: Vikram Karve <vikram.karve@progress.com>
vkarve-chef
approved these changes
Jun 27, 2023
vkarve-chef
changed the title
vkarve-chef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make deployment name an optional parameter. This allows for automatically defined unique deployment names in API response. While it is recommended that the deployment name be specified, it is not a mandatory parameter. This change will help in the scenario where unique naming convention applies. When the deployment name parameter is not set, the VM is named "deployment + deploymentID".
Check List
Validated change on local setup.
Not updating documentation as this is a non-standard scenario.