[Slider] Shouldn't be visible when in=false (mui#8894)

the-noob · Nov 17, 2017 · 30431f2 · 30431f2
1 parent 9c489fb
commit 30431f2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/src/transitions/Slide.js b/src/transitions/Slide.js
@@ -143,18 +143,6 @@ class Slide extends React.Component<ProvidedProps & Props, State> {
     firstMount: true,
   };
 
-  componentDidMount() {
-    if (!this.props.in) {
-      // We need to set initial translate values of transition element
-      // otherwise component will be shown when in=false.
-      const element = findDOMNode(this.transition);
-      if (element instanceof HTMLElement) {
-        element.style.visibility = 'visible';
-        setTranslateValue(this.props, element);
-      }
-    }
-  }
-
   componentWillReceiveProps() {
     this.setState({
       firstMount: false,

diff --git a/src/transitions/Slide.spec.js b/src/transitions/Slide.spec.js
@@ -203,8 +203,8 @@ describe('<Slide />', () => {
         </SlideNaked>,
       );
       const transition = findDOMNode(wrapper.instance().transition);
-      // $FlowFixMe
-      assert.notStrictEqual(transition.style.transform, undefined);
+      // $FlowExpectedError
+      assert.strictEqual(transition.style.visibility, 'hidden');
     });
   });