Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions workflows to latest #34

Merged
merged 6 commits into from
May 26, 2024
Merged

Update GitHub Actions workflows to latest #34

merged 6 commits into from
May 26, 2024

Conversation

leptos-null
Copy link
Member

What does this implement/fix? Explain your changes.

Changes from commits:

  • Update actions/checkout to v4
  • Always use latest theos/theos upstream
  • Remove TODO to use a matrix for release workflow
    • A matrix would be more difficult to manage because all the artifacts would need to be uploaded and then downloaded to attach to the release
  • Migrate to creating GitHub Releases using the official CLI
    • The actions/checkout action is no longer maintained
    • Also migrate to workflow specific-tokens instead of an access token stored in Secrets
  • Migrate to latest step output API
  • Switch test workflow to use same steps as release workflow
    • Using the a build workflow closer to the release workflow means we're testing the code closer what will be deployed

Does this close any currently open issues?

No

Any relevant logs, error output, etc?

Where has this been tested?

Operating System: macOS 11

Platform: macOS

Target Platform: iOS

@leptos-null
Copy link
Member Author

The CI for this pull request is failing (as intended) currently. #35 should fix these.

@RUGMJ
Copy link

RUGMJ commented May 18, 2024

Wouldnt keeping the theos version fixed be better to prevent a theos update breaking orion builds?

@leptos-null
Copy link
Member Author

Wouldnt keeping the theos version fixed be better to prevent a theos update breaking orion builds?

Yes, usually it's a good idea to version-pin dependencies, however theos is designed to be highly backward compatible.
This is also a theos repository.

@kabiroberai
Copy link
Member

let's merge #35 first and make CI green again, will review this after that.

A matrix would be more difficult to manage because
all the artifacts would need to be uploaded and then downloaded
to attach to the release
The `actions/create-release` action is no longer maintained.

Also migrate to workflow specific-tokens instead of an access
token stored in Secrets
Using the a build workflow closer to the release workflow
means we're testing the code we're actually deploying
Copy link
Member

@kabiroberai kabiroberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kabiroberai kabiroberai merged commit dd25553 into theos:master May 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants