Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jsx error #1315

Merged
merged 5 commits into from
Jul 26, 2023
Merged

fix jsx error #1315

merged 5 commits into from
Jul 26, 2023

Conversation

Megio
Copy link
Contributor

@Megio Megio commented Jul 26, 2023

Type of change

  • Documentation change
  • Bug fix

Summary of change

Fixed build issues, icons and performance

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • Changes for this new starter kit are being pushed to an integration branch instead of main
  • All dependencies are version locked
  • I have verified the fix works and introduces no further errors

@Megio Megio requested a review from kenslachtajr July 26, 2023 14:42
@Megio Megio self-assigned this Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit 2f39553
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/64c136251ed5920008128884

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for shopify-next-tailwind ready!

Name Link
🔨 Latest commit 2f39553
🔍 Latest deploy log https://app.netlify.com/sites/shopify-next-tailwind/deploys/64c1362565ed4e00080a2d96
😎 Deploy Preview https://deploy-preview-1315--shopify-next-tailwind.netlify.app/500
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kenslachtajr
kenslachtajr previously approved these changes Jul 26, 2023
kenslachtajr
kenslachtajr previously approved these changes Jul 26, 2023
markshenouda
markshenouda previously approved these changes Jul 26, 2023
@Megio Megio dismissed stale reviews from markshenouda and kenslachtajr via f2d00e7 July 26, 2023 15:02
@Megio Megio merged commit 280ecb3 into main Jul 26, 2023
13 checks passed
@Megio Megio deleted the fix-build branch July 26, 2023 15:09
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisdot-bot
Copy link

Hi @Megio. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to starter.dev. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants