Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shopify Analytics #1333

Merged
merged 4 commits into from
Oct 20, 2023
Merged

feat: Shopify Analytics #1333

merged 4 commits into from
Oct 20, 2023

Conversation

markshenouda
Copy link
Member

Type of change

  • Documentation change
  • Bug fix

Summary of change

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • Changes for this new starter kit are being pushed to an integration branch instead of main
  • All dependencies are version locked
  • This fix resolves #
  • I have verified the fix works and introduces no further errors

@markshenouda markshenouda self-assigned this Oct 20, 2023
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit e77cdcf
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/653240cf419a560008c19600

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for shopify-next-tailwind ready!

Name Link
🔨 Latest commit e77cdcf
🔍 Latest deploy log https://app.netlify.com/sites/shopify-next-tailwind/deploys/653240cfdca866000893744f
😎 Deploy Preview https://deploy-preview-1333--shopify-next-tailwind.netlify.app/500
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,51 @@
'use client';

import { useShopifyCookies } from '@shopify/hydrogen-react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can put this inside the import at line 6. otherwise we import the package 2 times.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Megio Megio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super PR! LGTM 🚀

@markshenouda markshenouda merged commit e233147 into main Oct 20, 2023
15 checks passed
@markshenouda markshenouda deleted the shopify-analytics branch October 20, 2023 09:09
@thisdot-bot
Copy link

Hi @markshenouda. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to starter.dev. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants