Regular parser performance improvements #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, -20% time in tests
…than SplStack, simplified backtrack()
…of string was reached, modified backtracks logic, added performance tests
|
By further analyzing Blackfire call graphs I see that tokenization is now a bottleneck, consumes 75% of time for "small" example and 97% of "full" one. Right now it uses an iterated regex approach, need to work on better one. |
|
Blackfire sounds like an interesting tool. I tried it once, but couldn't get it to work, maybe i'll give it another shot. |
…rnating matches which completes last performance bottleneck
|
By rewriting tokenizer to use single |
thunderer
added a commit
that referenced
this pull request
Jan 24, 2016
Regular parser performance improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @rhukster in #26 and #27 there are massive performance problems in
RegularParserwhen trying to parse big documents. This PR provides significant improvements for parsing speed while maintaining the correctness this parser was built for. Blackfire reports -91% performance improvement on "small" example and "full" completes in about 3.5s (which is at least 4500% improvement since it was reported that it didn't complete in more than half an hour).