Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting Reverb after BlepSynth has no effect #24

Closed
swesterfeld opened this issue Nov 10, 2023 · 2 comments
Closed

Inserting Reverb after BlepSynth has no effect #24

swesterfeld opened this issue Nov 10, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@swesterfeld
Copy link
Collaborator

If I create a BlepSynth device and insert a FreeVerb device after it, it doesn't sound different (so no reverb is applied). The same occurs if I use a CLAP Reverb plugin such as Dragon Fly. This used to work before.

I'm using

$ misc/version.sh 
0.2.0.nightly2311052133 441cbca2581a3cc6a91606fd2120a60f67c247eb 2023-11-01 17:48:43 +0100
@swesterfeld
Copy link
Collaborator Author

I did some further debugging on this, and the FreeVerb process function is called (as it should be). However, the order of processing is wrong, so the FreeVerb processing function gets called before the BlepSynth.

If I insert plugins in the "wrong" order, that is first insert the FreeVerb and put the BlepSynth after it, then the reverb gets applied.

@tim-janik
Copy link
Owner

Just a guess, could the ordering in combo.cc we wrong? This is where multiple processors are connected as children.

@tim-janik tim-janik added this to the v0.3.0 milestone Jan 27, 2024
@tim-janik tim-janik added the bug Something isn't working label Feb 10, 2024
swesterfeld added a commit to swesterfeld/anklang that referenced this issue Feb 14, 2024
Fixes tim-janik#24.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
tim-janik added a commit that referenced this issue Feb 21, 2024
* bug-fixes:
  ui/b/trackview.js: fix scale rounding that caused extra UI flicker
  README.md: link to Roadmap Discussions Feedback & Ideas: #52
  ase/combo.cc: fix combo insertion order for devices inserted at end
	Fixes #24.

Signed-off-by: Tim Janik <timj@gnu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants