Generate new fresh instance of library #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's an leaking issue when using multiple instances of the library on the same page, where config settings differ (app, user auth etc). The reason is that when the library is required through DI, a singleton is always returned which means multiple SDK instances can't be used on the same page/script.
This PR adds a new method
newInstancethat simply returns a new instance of the SDK class.Design choices
Instead of changing the default
module.exportbehaviour and thus breaking backwards compatibility, we just added a new optional method that can be used instead.Tests
Added one test.
Related dependencies
timekit-io/booking-js#152
Who should review it
@Trolzie