Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deleteResource to endpoints #50

Merged
merged 1 commit into from
Aug 16, 2018
Merged

add deleteResource to endpoints #50

merged 1 commit into from
Aug 16, 2018

Conversation

cdimitroulas
Copy link
Contributor

Motivation

Missing endpoint (deleteResource)

Design choices

Followed the style in the existing codebase

Side-effects/other

More functionality!

Tests

Added test in the same style as the existing ones

Known issues/limitations

Release dependencies

Who should review it

Anyone!

@laander
Copy link
Contributor

laander commented Aug 14, 2018

Good stuff @cdimitroulas , thanks for the PR! I'll make sure to merge this asap, hopefully tomorrow or in the next coming days 👍

@cdimitroulas
Copy link
Contributor Author

amazing, thanks!

@laander laander merged commit 35d80fa into timekit-io:master Aug 16, 2018
@laander
Copy link
Contributor

laander commented Aug 16, 2018

@cdimitroulas Released in v1.17.0 and published on npm

@cdimitroulas cdimitroulas deleted the delete-resource branch August 16, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants