Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove y-indexeddb #1771

Merged
merged 22 commits into from
Apr 2, 2023
Merged

refactor: remove y-indexeddb #1771

merged 22 commits into from
Apr 2, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Mar 31, 2023

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 2, 2023 7:57am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 7:57am

@himself65 himself65 temporarily deployed to development March 31, 2023 07:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:02 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Mar 31, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master    y-indexeddb                 +/- ##
===================================================================
> Bundle              2.83 MB        2.73 MB    -97.7 kB(-3.45%)   
> Initial JS          1.83 MB        1.73 MB    -97.7 kB(-5.34%)   
= Initial CSS         2.04 kB        2.04 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   36             37                  +1   
< Chunks                   35             36                  +1   
> Packages                131            128                  -3   
< Duplicates                1              2                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master    y-indexeddb                 +/- ##
===================================================================
> Bundle              2.72 MB        2.62 MB    -97.7 kB(-3.59%)   
> Initial JS          1.72 MB        1.63 MB    -97.7 kB(-5.67%)   
= Initial CSS         2.04 kB        2.04 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   34             35                  +1   
< Chunks                   33             34                  +1   
> Packages                131            128                  -3   
< Duplicates                1              2                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master    y-indexeddb                 +/- ##
===================================================================
< Bundle                508 B        16.6 kB   +16.1 kB(> 1000%)   
< Initial JS            508 B        16.6 kB   +16.1 kB(> 1000%)   
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                    1              2                  +1   
< Chunks                    1              2                  +1   
< Packages                  2              5                  +3   
= Duplicates                0              0                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Avoid cache wasting                                              

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview March 31, 2023 07:04 Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:06 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4a1e35
Status: ✅  Deploy successful!
Preview URL: https://b820dc08.affine.pages.dev
Branch Preview URL: https://y-indexeddb.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook March 31, 2023 07:06 Inactive
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 89.24% and project coverage change: +0.38 🎉

Comparison is base (f5574c6) 71.31% compared to head (b4a1e35) 71.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
+ Coverage   71.31%   71.70%   +0.38%     
==========================================
  Files         248      249       +1     
  Lines        4306     4397      +91     
  Branches      792      806      +14     
==========================================
+ Hits         3071     3153      +82     
- Misses       1053     1062       +9     
  Partials      182      182              
Flag Coverage Δ
e2etest 69.62% <49.45%> (-0.47%) ⬇️
unittest 38.82% <77.41%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/y-indexeddb/src/index.ts 88.88% <88.88%> (ø)
packages/workspace/src/local/crud.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development March 31, 2023 07:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:11 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 31, 2023 07:13 Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:14 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 31, 2023 07:16 Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 07:21 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 31, 2023 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 31, 2023 20:16 Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:46 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:46 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:46 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 07:46 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 2, 2023 07:54 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 2, 2023 07:57 Inactive
@himself65 himself65 merged commit ed8f07f into master Apr 2, 2023
@himself65 himself65 deleted the y-indexeddb branch April 2, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

duplicated update for multiple IndexeddbPersistence and single Y.Doc
1 participant