Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize electron macos header style #1774

Merged
merged 13 commits into from
Apr 2, 2023
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 31, 2023

Transparent sidebar

image
image

Hide traffic light when sidebar is not open

image

fix #1291
fix #1601

Kapture.2023-04-02.at.23.24.30.mp4

@pengx17 pengx17 temporarily deployed to development March 31, 2023 16:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 31, 2023 16:31 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 2, 2023 6:37pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 6:37pm

@pengx17 pengx17 temporarily deployed to development March 31, 2023 16:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 31, 2023 16:31 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 243f027
Status: ✅  Deploy successful!
Preview URL: https://033acf74.affine.pages.dev
Branch Preview URL: https://0332-feat-macos-header.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook March 31, 2023 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 31, 2023 16:35 Inactive
@himself65
Copy link
Contributor

Type error: File '/vercel/path0/apps/electron/layers/preload/preload.autogen.d.ts' not found.

@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01 ⚠️

Comparison is base (fa150a9) 71.77% compared to head (243f027) 71.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
- Coverage   71.77%   71.76%   -0.01%     
==========================================
  Files         249      249              
  Lines        4435     4441       +6     
  Branches      813      816       +3     
==========================================
+ Hits         3183     3187       +4     
- Misses       1068     1069       +1     
- Partials      184      185       +1     
Flag Coverage Δ
e2etest 69.03% <88.88%> (-0.01%) ⬇️
unittest 39.21% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/components/affine/pivots/styles.ts 28.00% <ø> (ø)
...omponents/affine/workspace-setting-detail/style.ts 84.21% <ø> (ø)
...ocksuite/block-suite-page-list/page-list/Empty.tsx 100.00% <ø> (ø)
...ocksuite/block-suite-page-list/page-list/styles.ts 100.00% <ø> (ø)
apps/web/src/components/page-detail-editor.tsx 70.58% <ø> (ø)
...web/src/components/pure/workspace-avatar/index.tsx 77.77% <ø> (ø)
...e/workspace-slider-bar/WorkspaceSelector/styles.ts 100.00% <ø> (ø)
...ponents/pure/workspace-slider-bar/shared-styles.ts 36.84% <ø> (ø)
apps/web/src/layouts/styles.ts 100.00% <ø> (ø)
.../pages/public-workspace/[workspaceId]/[pageId].tsx 74.28% <ø> (ø)
... and 8 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook March 31, 2023 21:07 Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development March 31, 2023 21:08 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 2, 2023 15:23 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 2, 2023 15:25 Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:47 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:47 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:47 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:47 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 2, 2023 15:50 Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 2, 2023 15:52 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 2, 2023 15:53 Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 2, 2023 18:35 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 2, 2023 18:35 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 2, 2023 18:37 Inactive
@himself65 himself65 merged commit e0eecff into master Apr 2, 2023
@himself65 himself65 deleted the 0332/feat/macos-header branch April 2, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Electron] Adapt UI layout for desktop app Double click top area should change window size
2 participants