Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: MacOS code signing #1795

Merged
merged 6 commits into from
Apr 3, 2023
Merged

build: MacOS code signing #1795

merged 6 commits into from
Apr 3, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 3, 2023

@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:15 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 3, 2023 9:38pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 9:38pm

@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:15 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:15 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:15 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:17 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 3, 2023 14:18 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a05feb
Status: ✅  Deploy successful!
Preview URL: https://218569a6.affine.pages.dev
Branch Preview URL: https://0403-build-macos-sign.affine.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:19 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83000fa) 71.92% compared to head (2a05feb) 71.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1795   +/-   ##
=======================================
  Coverage   71.92%   71.92%           
=======================================
  Files         249      249           
  Lines        4470     4470           
  Branches      822      822           
=======================================
  Hits         3215     3215           
  Misses       1069     1069           
  Partials      186      186           
Flag Coverage Δ
e2etest 69.68% <ø> (ø)
unittest 39.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-preview April 3, 2023 14:23 Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 14:23 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 3, 2023 14:26 Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:10 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 3, 2023 15:16 Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:22 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:22 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:22 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:22 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 3, 2023 15:24 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 3, 2023 15:25 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 3, 2023 15:27 Inactive
@pengx17 pengx17 marked this pull request as ready for review April 3, 2023 15:53
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 3, 2023 21:28 Inactive
@perfsee
Copy link

perfsee bot commented Apr 3, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ld/macos-sign                 +/- ##
===================================================================
> Bundle              2.84 MB        2.74 MB     -103 kB(-3.62%)   
> Initial JS          1.84 MB        1.74 MB     -103 kB(-5.58%)   
= Initial CSS         2.05 kB        2.05 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   36             37                  +1   
< Chunks                   35             36                  +1   
> Packages                132            128                  -4   
= Duplicates                2              2                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ld/macos-sign                 +/- ##
===================================================================
> Bundle              2.73 MB        2.63 MB     -103 kB(-3.76%)   
> Initial JS          1.74 MB        1.63 MB     -103 kB(-5.92%)   
= Initial CSS         2.05 kB        2.05 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   34             35                  +1   
< Chunks                   33             34                  +1   
> Packages                132            128                  -4   
= Duplicates                2              2                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ld/macos-sign                 +/- ##
===================================================================
< Bundle                508 B        16.6 kB   +16.1 kB(> 1000%)   
< Initial JS            508 B        16.6 kB   +16.1 kB(> 1000%)   
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                    1              2                  +1   
< Chunks                    1              2                  +1   
< Packages                  2              5                  +3   
= Duplicates                0              0                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Avoid cache wasting                                              

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 3, 2023 21:38 Inactive
@himself65 himself65 merged commit b1618e9 into master Apr 3, 2023
@himself65 himself65 deleted the 0403/build/macos-sign branch April 3, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Code Signing macOS Application for client
3 participants