Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shortcut for expand/collapse of sidebar #1797

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

adityash1
Copy link
Contributor

Closes #1784

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 3, 2023 9:43pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 9:43pm

@vercel
Copy link

vercel bot commented Apr 3, 2023

@adityash1 is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 3, 2023 20:03 Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:20 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:20 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:20 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:20 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:23 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:23 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:23 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 3, 2023 20:23 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 3, 2023 20:24 Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:12 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -2.19 ⚠️

Comparison is base (b365887) 71.90% compared to head (1370a6e) 69.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
- Coverage   71.90%   69.71%   -2.19%     
==========================================
  Files         249      242       -7     
  Lines        4470     3992     -478     
  Branches      822      545     -277     
==========================================
- Hits         3214     2783     -431     
+ Misses       1070     1019      -51     
- Partials      186      190       +4     
Flag Coverage Δ
e2etest 69.66% <71.42%> (+<0.01%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/pure/workspace-slider-bar/index.tsx 94.11% <71.42%> (-5.89%) ⬇️

... and 104 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 3, 2023 21:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:19 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) April 3, 2023 21:20
@himself65
Copy link
Contributor

Thanks for contributing AFFiNE!

@himself65 himself65 temporarily deployed to development April 3, 2023 21:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 3, 2023 21:24 — with GitHub Actions Inactive
@himself65 himself65 disabled auto-merge April 3, 2023 21:39
@himself65 himself65 merged commit cd089ed into toeverything:master Apr 3, 2023
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 3, 2023 21:43 Inactive
@himself65 himself65 mentioned this pull request Apr 3, 2023
7 tasks
@adityash1 adityash1 deleted the feat_sidebar_shortcut_1784 branch April 4, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add shortcut support for Collapse/Expand Sidebar
2 participants