Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: abstract workspace provider #1809

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 temporarily deployed to development April 4, 2023 03:57 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 4, 2023 4:14am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 4:14am

@himself65 himself65 temporarily deployed to development April 4, 2023 03:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 03:59 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (215bb24) 71.72% compared to head (718d059) 71.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1809      +/-   ##
==========================================
+ Coverage   71.72%   71.75%   +0.02%     
==========================================
  Files         249      249              
  Lines        4503     4496       -7     
  Branches      826      824       -2     
==========================================
- Hits         3230     3226       -4     
  Misses       1086     1086              
+ Partials      187      184       -3     
Flag Coverage Δ
e2etest 69.46% <100.00%> (+0.02%) ⬆️
unittest 39.75% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/atoms/index.ts 100.00% <ø> (+18.42%) ⬆️
apps/web/src/pages/_app.tsx 72.72% <ø> (ø)
packages/workspace/src/type.ts 100.00% <ø> (ø)
apps/web/src/layouts/index.tsx 89.84% <100.00%> (+1.47%) ⬆️
apps/web/src/plugins/affine/index.tsx 65.55% <100.00%> (+0.38%) ⬆️
apps/web/src/plugins/local/index.tsx 75.00% <100.00%> (+3.57%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 718d059
Status: ✅  Deploy successful!
Preview URL: https://718ae50e.affine.pages.dev
Branch Preview URL: https://himself65-refactor-workspace-tw5b.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 4, 2023 04:11 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 4, 2023 04:14 Inactive
@himself65 himself65 merged commit 5129ab3 into master Apr 4, 2023
@himself65 himself65 deleted the himself65/refactor-workspace-provider branch April 4, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant