Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use radix ui on workspace avatar #1819

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 4, 2023 9:09pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 9:09pm

@himself65 himself65 temporarily deployed to development April 4, 2023 20:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:08 — with GitHub Actions Inactive
@himself65 himself65 changed the title Himself65/0404 refactor avatar refactor: use radix ui on workspace avatar Apr 4, 2023
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 4, 2023 20:10 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4d9b3c
Status: ✅  Deploy successful!
Preview URL: https://f8670a62.affine.pages.dev
Branch Preview URL: https://himself65-0404-refactor-avat.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development April 4, 2023 20:13 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Apr 4, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …factor-avatar                 +/- ##
===================================================================
< Bundle              2.79 MB        2.79 MB    +3.11 kB(+0.11%)   
< Initial JS          1.74 MB        1.75 MB    +4.54 kB(+0.26%)   
< Initial CSS         2.37 kB        2.51 kB      +137 B(+5.78%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   38             38                       
= Chunks                   36             36                       
< Packages                129            132                  +3   
< Duplicates                2              4                  +2   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …factor-avatar                 +/- ##
===================================================================
< Bundle              2.68 MB        2.68 MB    +3.11 kB(+0.12%)   
< Initial JS          1.64 MB        1.64 MB    +4.54 kB(+0.28%)   
< Initial CSS         2.37 kB        2.51 kB      +137 B(+5.78%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   36             36                       
= Chunks                   34             34                       
< Packages                129            132                  +3   
< Duplicates                2              4                  +2   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …factor-avatar                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 temporarily deployed to development April 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:13 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 4, 2023 20:13 Inactive
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (a24b747) 71.02% compared to head (e4d9b3c) 70.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
- Coverage   71.02%   70.91%   -0.11%     
==========================================
  Files         251      251              
  Lines        4669     4656      -13     
  Branches      916      903      -13     
==========================================
- Hits         3316     3302      -14     
- Misses       1182     1184       +2     
+ Partials      171      170       -1     
Flag Coverage Δ
e2etest 69.46% <100.00%> (-0.08%) ⬇️
storybook-test 40.35% <100.00%> (-0.55%) ⬇️
unittest 39.97% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onent/src/components/workspace-avatar/index.css.ts 100.00% <100.00%> (ø)
...omponent/src/components/workspace-avatar/index.tsx 95.00% <100.00%> (+3.82%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 4, 2023 20:36 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:36 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:36 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:36 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:36 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:38 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 4, 2023 20:38 Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 20:39 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 4, 2023 20:42 Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:06 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 4, 2023 21:06 Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 4, 2023 21:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 4, 2023 21:09 Inactive
@himself65 himself65 merged commit ae4339e into master Apr 4, 2023
@himself65 himself65 deleted the himself65/0404-refactor-avatar branch April 4, 2023 21:14
@himself65 himself65 mentioned this pull request Apr 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant