Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toast for workspace deletion #1825

Merged

Conversation

adityash1
Copy link
Contributor

Closes #1702

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 5, 2023 0:59am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:59am

@vercel
Copy link

vercel bot commented Apr 5, 2023

@adityash1 is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 5, 2023 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 5, 2023 12:17 Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:21 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:21 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:21 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:21 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:21 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:23 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:24 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:24 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:24 — with GitHub Actions Inactive
@adityash1 adityash1 temporarily deployed to development April 5, 2023 12:24 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (116caff) 70.98% compared to head (faccc48) 70.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
- Coverage   70.98%   70.98%   -0.01%     
==========================================
  Files         251      251              
  Lines        4656     4659       +3     
  Branches      910      903       -7     
==========================================
+ Hits         3305     3307       +2     
  Misses       1182     1182              
- Partials      169      170       +1     
Flag Coverage Δ
e2etest 69.59% <100.00%> (+0.02%) ⬆️
storybook-test 40.35% <0.00%> (ø)
unittest 39.97% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/affine/workspace-setting-detail/index.tsx 80.48% <ø> (ø)
packages/workspace/src/type.ts 100.00% <ø> (ø)
...pace-setting-detail/panel/general/delete/index.tsx 84.61% <100.00%> (+1.28%) ⬆️
apps/web/src/utils/toast.ts 83.33% <100.00%> (+8.33%) ⬆️
packages/component/src/ui/toast/toast.ts 67.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-preview April 5, 2023 12:37 Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 12:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 12:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 12:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 12:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 12:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 5, 2023 12:59 Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 13:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 13:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 13:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 13:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 5, 2023 13:00 — with GitHub Actions Inactive
@himself65 himself65 merged commit 0c87bf3 into toeverything:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

There should be a toast message prompt after a workspace has been deleted
2 participants