Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add root pinboard & rename pivots to pinboard #1843

Merged
merged 18 commits into from
Apr 7, 2023
Merged

Conversation

QiShaoXuan
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6ed098d
Status: ✅  Deploy successful!
Preview URL: https://fa69861e.affine.pages.dev
Branch Preview URL: https://feat-root-pivot.affine.pages.dev

View logs

@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:15 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:15 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:15 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:15 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 7, 2023 9:54pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 9:54pm

@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:15 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:17 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 58.69% and project coverage change: -26.55 ⚠️

Comparison is base (d4b2b9a) 75.00% compared to head (6ed098d) 48.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1843       +/-   ##
===========================================
- Coverage   75.00%   48.45%   -26.55%     
===========================================
  Files         250      199       -51     
  Lines        4760     3725     -1035     
  Branches      924      807      -117     
===========================================
- Hits         3570     1805     -1765     
- Misses        993     1742      +749     
+ Partials      197      178       -19     
Flag Coverage Δ
e2etest ?
storybook-test 41.96% <0.00%> (-0.06%) ⬇️
unittest 47.31% <59.12%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/affine/operation-menu-items/CopyLink.tsx 44.44% <0.00%> (ø)
.../components/affine/operation-menu-items/MoveTo.tsx 10.00% <0.00%> (-90.00%) ⬇️
...ts/affine/pinboard/pinboard-menu/SearchContent.tsx 11.11% <ø> (ø)
.../block-suite-page-list/page-list/OperationCell.tsx 5.88% <0.00%> (-54.73%) ⬇️
...ite/header/header-right-items/EditorOptionMenu.tsx 2.94% <0.00%> (-63.73%) ⬇️
...ents/pure/workspace-slider-bar/changeLog/index.tsx 50.00% <ø> (-50.00%) ⬇️
...src/components/pure/workspace-slider-bar/index.tsx 72.97% <ø> (-21.63%) ⬇️
apps/web/src/utils/blocksuite.ts 9.09% <0.00%> (-90.91%) ⬇️
apps/web/src/hooks/affine/use-pinboard-handler.ts 52.38% <18.75%> (ø)
...ents/affine/pinboard/pinboard-render/EmptyItem.tsx 33.33% <33.33%> (ø)
... and 9 more

... and 161 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-preview April 7, 2023 06:19 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 7, 2023 06:22 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:33 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:33 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 06:33 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:25 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:25 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:25 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:25 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:25 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:27 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 7, 2023 10:28 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 7, 2023 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 7, 2023 10:30 Inactive
@QiShaoXuan QiShaoXuan enabled auto-merge (squash) April 7, 2023 10:47
@himself65
Copy link
Contributor

Need rebase

# Conflicts:
#	apps/web/src/components/pure/workspace-slider-bar/changeLog/index.tsx
#	apps/web/src/components/pure/workspace-slider-bar/shared-styles.ts
@himself65 himself65 temporarily deployed to development April 7, 2023 21:48 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:48 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:48 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:48 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:48 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:50 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 7, 2023 21:51 Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 7, 2023 21:51 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 7, 2023 21:54 Inactive
@QiShaoXuan QiShaoXuan merged commit e50bf9f into master Apr 7, 2023
@QiShaoXuan QiShaoXuan deleted the feat/root-pivot branch April 7, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants