fix: dnd workspace list will cause page to reload #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …ix/dnd-reload +/- ##
===================================================================
< Bundle 2.89 MB 2.89 MB +207 B(+0.01%)
< Initial JS 1.81 MB 1.81 MB +117 B(+0.01%)
= Initial CSS 2.51 kB 2.51 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 38 38
= Chunks 36 36
= Packages 142 142
= Duplicates 7 7
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …ix/dnd-reload +/- ##
===================================================================
< Bundle 2.78 MB 2.78 MB +207 B(+0.01%)
< Initial JS 1.7 MB 1.7 MB +117 B(+0.01%)
= Initial CSS 2.51 kB 2.51 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 36 36
= Chunks 34 34
= Packages 142 142
= Duplicates 7 7
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …ix/dnd-reload +/- ##
===================================================================
= Bundle 16.5 kB 16.5 kB
= Initial JS 16.5 kB 16.5 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
Deploying with
|
| Latest commit: |
d66cc6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6346ff34.affine.pages.dev |
| Branch Preview URL: | https://0407-fix-dnd-reload.affine.pages.dev |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
+ Coverage 73.70% 74.78% +1.08%
==========================================
Files 250 250
Lines 4757 4760 +3
Branches 930 924 -6
==========================================
+ Hits 3506 3560 +54
+ Misses 1052 1003 -49
+ Partials 199 197 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
himself65
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
useTransitionto get rid of reloading issue when rearranging workspaces🤖 Generated by Copilot at e07770a
Summary
🚫🔧🔄
This pull request improves the user interface and performance of the workspace list modal component. It adds a
disabledprop and a transition effect to the modal, and refactors the workspaces data fetching logic to a separate component. It also updates theWorkspaceListcomponent to accept adisabledprop.Walkthrough
disabledprop toWorkspaceListandWorkspaceListItemcomponents to disable drag and drop and opacity when transitioning (link, link, link, link, link)useTransitionhook to create a transition state and function for theWorkspaceListModalcomponent and pass it to theWorkspaceListcomponent as thedisabledprop (link, link)setWorkspacesfunction with thetransitionfunction to update the workspaces order after a drag and drop action without unmounting or remounting the modal component (link)WorkspaceListModalto a separate componentWorkspacesSuspensein./apps/web/src/layouts/index.tsx(link, link)