Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show border around pagetitle when renaming #4080

Conversation

ideakaran
Copy link
Contributor

fix: #4056

Showed a border around the page title only when title input is on focus.

@codesandbox
Copy link

codesandbox bot commented Aug 31, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
affine-dev-docs ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 7:06pm

@vercel
Copy link

vercel bot commented Aug 31, 2023

@ideakaran is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a pretty fast fix. Thank u!

@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:55 — with GitHub Actions Inactive
@nx-cloud
Copy link

nx-cloud bot commented Aug 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8231886. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.03% ⚠️

Comparison is base (4091ff8) 66.09% compared to head (8231886) 65.07%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4080      +/-   ##
==========================================
- Coverage   66.09%   65.07%   -1.03%     
==========================================
  Files         397      394       -3     
  Lines       12040    12016      -24     
  Branches     1220     1217       -3     
==========================================
- Hits         7958     7819     -139     
- Misses       3778     3879     +101     
- Partials      304      318      +14     
Flag Coverage Δ
e2e-plugin-test 37.32% <ø> (ø)
e2etest 59.14% <ø> (ø)
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 ?
e2etest-windows-latest-x64 ?
server-e2etest 42.23% <ø> (-0.09%) ⬇️
server-test 68.64% <ø> (ø)
unittest 49.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:59 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:59 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:59 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 21:59 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 22:00 — with GitHub Actions Inactive
@ideakaran ideakaran temporarily deployed to development August 31, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 merged commit b18596f into toeverything:master Aug 31, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mode buttons and title disappear while renaming untitled doc
2 participants