Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable set-db-location step #4263

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 7, 2023

fix #4262

@codesandbox
Copy link

codesandbox bot commented Sep 7, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
affine-dev-docs ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 3:39pm
affine-prod-temp ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 3:39pm

@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:53 — with GitHub Actions Inactive
@nx-cloud
Copy link

nx-cloud bot commented Sep 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f09e90b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@pengx17 pengx17 temporarily deployed to development September 7, 2023 08:56 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12% ⚠️

Comparison is base (2813ad3) 66.84% compared to head (f09e90b) 66.72%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4263      +/-   ##
==========================================
- Coverage   66.84%   66.72%   -0.12%     
==========================================
  Files         394      394              
  Lines       12363    12362       -1     
  Branches     1123     1122       -1     
==========================================
- Hits         8264     8249      -15     
- Misses       3778     3792      +14     
  Partials      321      321              
Flag Coverage Δ
e2e-plugin-test 36.53% <0.00%> (-0.05%) ⬇️
e2etest 57.29% <100.00%> (-0.09%) ⬇️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 45.53% <100.00%> (-0.23%) ⬇️
e2etest-windows-latest-x64 ?
server-e2etest 53.01% <100.00%> (+<0.01%) ⬆️
server-test 65.98% <ø> (ø)
unittest 53.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...components/affine/create-workspace-modal/index.tsx 45.71% <100.00%> (-13.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:41 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:41 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:41 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:41 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:46 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 15:46 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 17:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 17:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 17:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 17:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 17:31 — with GitHub Actions Inactive
@pengx17 pengx17 added this pull request to the merge queue Sep 7, 2023
Merged via the queue into master with commit bf3a337 Sep 7, 2023
20 of 22 checks passed
@pengx17 pengx17 deleted the xp/0907/fix/disable-set-db-location branch September 7, 2023 17:59
Brooooooklyn pushed a commit that referenced this pull request Sep 24, 2023
Brooooooklyn pushed a commit that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The custom location feature is no longer working and should be removed from the process
2 participants