Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better transition #4267

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 7, 2023

20230907-175041.mp4

@codesandbox
Copy link

codesandbox bot commented Sep 7, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
affine-dev-docs ⬜️ Ignored (Inspect) Sep 7, 2023 9:50am
affine-prod-temp ⬜️ Ignored (Inspect) Sep 7, 2023 9:50am

@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:50 — with GitHub Actions Inactive
@nx-cloud
Copy link

nx-cloud bot commented Sep 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72bbddd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=build --parallel=5

Sent with 💌 from NxCloud.

@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: +0.02% 🎉

Comparison is base (2813ad3) 66.84% compared to head (72bbddd) 66.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4267      +/-   ##
==========================================
+ Coverage   66.84%   66.86%   +0.02%     
==========================================
  Files         394      394              
  Lines       12363    12375      +12     
  Branches     1123     1124       +1     
==========================================
+ Hits         8264     8275      +11     
  Misses       3778     3778              
- Partials      321      322       +1     
Flag Coverage Δ
e2e-plugin-test 36.42% <6.25%> (-0.16%) ⬇️
e2etest 57.35% <93.75%> (-0.03%) ⬇️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 45.73% <50.00%> (-0.03%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-e2etest 52.96% <50.00%> (-0.04%) ⬇️
server-test 65.98% <ø> (ø)
unittest 53.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../component/src/components/workspace-list/index.tsx 95.45% <93.33%> (-4.55%) ⬇️
apps/core/src/providers/modal-provider.tsx 83.51% <100.00%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 7, 2023 09:59 — with GitHub Actions Inactive
@himself65 himself65 added this pull request to the merge queue Sep 7, 2023
Merged via the queue into master with commit 0c4277e Sep 7, 2023
23 of 25 checks passed
@himself65 himself65 deleted the xp/0907/fix/better-workspace-list-dnd-transition branch September 7, 2023 15:39
Brooooooklyn pushed a commit that referenced this pull request Sep 24, 2023
Brooooooklyn pushed a commit that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants