Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): better orm #7502

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat(infra): better orm #7502

merged 1 commit into from
Jul 18, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jul 15, 2024

No description provided.

Copy link

graphite-app bot commented Jul 15, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review July 15, 2024 03:43
@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Jul 15, 2024
Copy link
Member Author

EYHN commented Jul 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 15, 2024

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.71%. Comparing base (133888d) to head (9fe77ba).

Files Patch % Lines
...es/common/infra/src/orm/core/adapters/yjs/table.ts 96.55% 1 Missing ⚠️
packages/common/infra/src/orm/core/table.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7502      +/-   ##
==========================================
+ Coverage   57.69%   57.71%   +0.02%     
==========================================
  Files         909      909              
  Lines       40289    40309      +20     
  Branches     4556     4564       +8     
==========================================
+ Hits        23244    23265      +21     
- Misses      16691    16692       +1     
+ Partials      354      352       -2     
Flag Coverage Δ
server-test 78.42% <ø> (-0.01%) ⬇️
unittest 29.16% <95.34%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 18, 2024

Merge activity

@graphite-app graphite-app bot merged commit 9fe77ba into canary Jul 18, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/better-orm branch July 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants