-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add doc/collection/tag select hook #7593
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7253e1a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## catsjuice/feat/scope-context-modals #7593 +/- ##
=======================================================================
- Coverage 57.59% 57.54% -0.05%
=======================================================================
Files 911 914 +3
Lines 40565 40619 +54
Branches 4615 4620 +5
=======================================================================
+ Hits 23362 23374 +12
- Misses 16852 16895 +43
+ Partials 351 350 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b4e6aa6
to
20d7817
Compare
32470a3
to
eecbe82
Compare
5f6d84d
to
211131f
Compare
eecbe82
to
4c7034d
Compare
211131f
to
6ab4b4f
Compare
Merge activity
|
### New Hooks >⚠️ These hooks are not used yet so we can't add tests for now - Open page select dialog > SelectPage's content is shared with edit-collection pages mode, now we don't need to pass page-list to it. ```tsx const open = useSelectPage() const ids: string[] = await open() ``` - Open collection select dialog ```tsx const open = useSelectCollection() const ids: string[] = await open() ``` - Open tag select dialog >⚠️ Tag select's favorite operation is not implemented ```tsx const open = useSelectTag() const ids: string[] = await open() ```
4c7034d
to
8646221
Compare
6ab4b4f
to
7253e1a
Compare
New Hooks
Open page select dialog
Open collection select dialog
Open tag select dialog