Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add doc/collection/tag select hook #7593

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jul 24, 2024

New Hooks

⚠️ These hooks are not used yet so we can't add tests for now

  • Open page select dialog

    SelectPage's content is shared with edit-collection pages mode, now we don't need to pass page-list to it.

    const open = useSelectPage()
    const ids: string[] = await open()
  • Open collection select dialog

    const open = useSelectCollection()
    const ids: string[] = await open()
  • Open tag select dialog

    ⚠️ Tag select's favorite operation is not implemented

    const open = useSelectTag()
    const ids: string[] = await open()

Copy link

graphite-app bot commented Jul 24, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Jul 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 24, 2024

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 17.89474% with 78 lines in your changes missing coverage. Please review.

Project coverage is 57.54%. Comparing base (8646221) to head (7253e1a).

Files Patch % Lines
...nts/page-list/view/edit-collection/select-page.tsx 0.00% 27 Missing ⚠️
...onents/page-list/collections/select-collection.tsx 7.14% 26 Missing ⚠️
.../core/src/components/page-list/tags/select-tag.tsx 10.52% 17 Missing ⚠️
.../components/page-list/selector/selector-layout.tsx 16.66% 5 Missing ⚠️
...ents/page-list/view/edit-collection/rules-mode.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           catsjuice/feat/scope-context-modals    #7593      +/-   ##
=======================================================================
- Coverage                                57.59%   57.54%   -0.05%     
=======================================================================
  Files                                      911      914       +3     
  Lines                                    40565    40619      +54     
  Branches                                  4615     4620       +5     
=======================================================================
+ Hits                                     23362    23374      +12     
- Misses                                   16852    16895      +43     
+ Partials                                   351      350       -1     
Flag Coverage Δ
server-test 78.59% <ø> (+<0.01%) ⬆️
unittest 28.86% <17.89%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the mod:i18n Related to i18n label Jul 25, 2024
@CatsJuice CatsJuice marked this pull request as ready for review July 25, 2024 07:30
@EYHN EYHN force-pushed the catsjuice/feat/scope-context-modals branch from 32470a3 to eecbe82 Compare July 25, 2024 08:18
@CatsJuice CatsJuice force-pushed the catsjuice/feat/scope-context-modals branch from eecbe82 to 4c7034d Compare July 25, 2024 09:58
Copy link

graphite-app bot commented Jul 26, 2024

Merge activity

  • Jul 25, 10:49 PM EDT: forehalo added this pull request to the Graphite merge queue.
  • Jul 25, 11:34 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Test (5)').

### New Hooks
> ⚠️ These hooks are not used yet so we can't add tests for now
- Open page select dialog
  > SelectPage's content is shared with edit-collection pages mode, now we don't need to pass page-list to it.
  ```tsx
  const open = useSelectPage()
  const ids: string[] = await open()
  ```

- Open collection select dialog
  ```tsx
  const open = useSelectCollection()
  const ids: string[] = await open()
  ```

- Open tag select dialog
  > ⚠️ Tag select's favorite operation is not implemented
  ```tsx
  const open = useSelectTag()
  const ids: string[] = await open()
  ```
@forehalo forehalo force-pushed the catsjuice/feat/scope-context-modals branch from 4c7034d to 8646221 Compare July 26, 2024 03:19
@forehalo forehalo changed the base branch from catsjuice/feat/scope-context-modals to canary July 26, 2024 03:33
@forehalo forehalo merged commit c63d007 into canary Jul 26, 2024
32 checks passed
@forehalo forehalo deleted the catsjuice/feat/af-1110 branch July 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants