Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update outline viewer style #7641

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Jul 29, 2024

What changes

  • Update responsive style and fix some bug of outline viewer (chore: update outline viewer style blocksuite#7759)
  • Change left and right padding of full-width editor from 15px to 72px
  • Hide outline viewer when side outline panel is opened (BS-987)
  • Add entries of outline panel and frame panel in more menu of detail page header ( BS-996 , BS-1006)
  • Add outline viewer to dock peek preview ( BS-995 )
  • Add more e2e tests for outline viewer

Copy link
Contributor Author

L-Sun commented Jul 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 29, 2024

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.35%. Comparing base (545bd03) to head (bd31c83).

Files Patch % Lines
...dules/peek-view/view/doc-preview/doc-peek-view.tsx 0.00% 7 Missing ⚠️
...src/components/blocksuite/outline-viewer/index.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7641      +/-   ##
==========================================
+ Coverage   55.33%   55.35%   +0.01%     
==========================================
  Files        1003     1005       +2     
  Lines       43396    43420      +24     
  Branches     5182     5190       +8     
==========================================
+ Hits        24013    24034      +21     
- Misses      19022    19025       +3     
  Partials      361      361              
Flag Coverage Δ
server-test 78.91% <ø> (+0.07%) ⬆️
unittest 26.52% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch from 29c57eb to b19bb71 Compare July 29, 2024 17:53
@L-Sun L-Sun marked this pull request as ready for review July 29, 2024 18:41
@graphite-app graphite-app bot requested review from pengx17, CatsJuice, forehalo, JimmFly and EYHN and removed request for pengx17 July 29, 2024 18:41
@L-Sun L-Sun marked this pull request as draft July 30, 2024 03:14
@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch from b19bb71 to 3e50c5e Compare July 30, 2024 16:42
@github-actions github-actions bot added mod:i18n Related to i18n test Related to test cases labels Jul 30, 2024
@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch 3 times, most recently from 2474d75 to 96de91b Compare July 31, 2024 08:58
@L-Sun L-Sun changed the base branch from canary to 07-31-chore_bump_blocksuite July 31, 2024 08:58
@L-Sun L-Sun mentioned this pull request Jul 31, 2024
@L-Sun L-Sun marked this pull request as ready for review July 31, 2024 08:58
Copy link

perfsee bot commented Jul 31, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …_viewer_style                 +/- ##
===================================================================
< Bundle              22.7 MB        22.7 MB    +21.8 kB(+0.10%)   
< Initial JS          9.58 MB        9.65 MB    +68.2 kB(+0.71%)   
< Initial CSS          182 kB         188 kB    +5.67 kB(+3.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   67             67                       
= Chunks                   65             65                       
= Packages                294            294                       
= Duplicates               25             25                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Improve page load speed with `preconnect` or `dns-prefetch`      
! Avoid cache wasting                                              

@L-Sun L-Sun force-pushed the 07-31-chore_bump_blocksuite branch from 04aac75 to 8eb77cd Compare July 31, 2024 09:07
@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch from 96de91b to f801141 Compare July 31, 2024 09:08
@L-Sun L-Sun changed the title FIX(core): update outline viewer style fix(core): update outline viewer style Aug 2, 2024
@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch from 7492506 to 3c0f8e2 Compare August 3, 2024 07:20
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app mod:dev labels Aug 3, 2024
@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch 2 times, most recently from 78b2657 to eeae559 Compare August 5, 2024 03:36
Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

## What changes
- Update responsive style and fix some bug of outline viewer (toeverything/blocksuite#7759)
- Change left and right padding of full-width editor from `15px` to `72px`
- Hide outline viewer when side outline panel is opened ([BS-987](https://linear.app/affine-design/issue/BS-987/逻辑-bug-toc-入口和-toc-侧边栏共存))
- Add entries of outline panel and frame panel in more menu of detail page header ( [BS-996](https://linear.app/affine-design/issue/BS-996/page-mode-下的-page-option-缺少-view-table-of-contents-的入口) , [BS-1006](https://linear.app/affine-design/issue/BS-1006/edgeless-mode-的-page-options-里缺少-view-all-frames))
- Add outline viewer to dock peek preview ( [BS-995](https://linear.app/affine-design/issue/BS-995/center-peek-里缺少-quick-toc-的入口) )
- Add more e2e tests for outline viewer
@L-Sun L-Sun force-pushed the 07-30-chore_core_update_outline_viewer_style branch from eeae559 to bd31c83 Compare August 5, 2024 03:57
@graphite-app graphite-app bot merged commit bd31c83 into canary Aug 5, 2024
34 checks passed
@graphite-app graphite-app bot deleted the 07-30-chore_core_update_outline_viewer_style branch August 5, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants