Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon color active style #7656

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 30, 2024

fix PD-1500

Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Jul 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review July 30, 2024 08:27
Copy link

nx-cloud bot commented Jul 30, 2024

Copy link
Member

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forehalo approved this PR from Slack with Graphite

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.59%. Comparing base (d80c80e) to head (ea7066d).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7656   +/-   ##
=======================================
  Coverage   27.59%   27.59%           
=======================================
  Files         741      741           
  Lines       18358    18358           
  Branches     3357     3357           
=======================================
  Hits         5065     5065           
  Misses      12987    12987           
  Partials      306      306           
Flag Coverage Δ
unittest 27.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/07-30-fix_icon_color_active_style branch from e7ed7d1 to 07c1736 Compare July 30, 2024 10:10
@pengx17 pengx17 force-pushed the xp/07-30-fix_remove_shadow_for_bordered_main_container branch from 2e21cfc to 1517280 Compare July 30, 2024 10:13
@pengx17 pengx17 force-pushed the xp/07-30-fix_icon_color_active_style branch from 07c1736 to 9b3aaaf Compare July 30, 2024 10:13
@pengx17 pengx17 force-pushed the xp/07-30-fix_remove_shadow_for_bordered_main_container branch from 1517280 to d80c80e Compare July 30, 2024 11:38
Copy link

graphite-app bot commented Jul 30, 2024

Merge activity

@pengx17 pengx17 changed the base branch from xp/07-30-fix_remove_shadow_for_bordered_main_container to canary July 30, 2024 11:50
@pengx17 pengx17 force-pushed the xp/07-30-fix_icon_color_active_style branch from 9b3aaaf to ea7066d Compare July 30, 2024 11:51
@graphite-app graphite-app bot merged commit ea7066d into canary Jul 30, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/07-30-fix_icon_color_active_style branch July 30, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants