Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make chat button click event work fine #7658

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

darkskygit
Copy link
Member

fix PD-1504

Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 30, 2024

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (48e17fa) to head (49529b7).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7658       +/-   ##
===========================================
- Coverage   56.55%   27.61%   -28.95%     
===========================================
  Files         949      741      -208     
  Lines       42274    18381    -23893     
  Branches     4910     3356     -1554     
===========================================
- Hits        23910     5075    -18835     
+ Misses      18005    13000     -5005     
+ Partials      359      306       -53     
Flag Coverage Δ
server-test ?
unittest 27.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit requested review from pengx17 and EYHN July 31, 2024 09:18
Copy link

graphite-app bot commented Jul 31, 2024

Merge activity

@darkskygit darkskygit force-pushed the darksky/fix-chat-button-status branch from c7923e3 to 49529b7 Compare July 31, 2024 09:25
@graphite-app graphite-app bot merged commit 49529b7 into canary Jul 31, 2024
32 checks passed
@graphite-app graphite-app bot deleted the darksky/fix-chat-button-status branch July 31, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants