Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ai chat block added later should be with higher index #7660

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Jul 30, 2024

Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donteatfriedrice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 30, 2024

@donteatfriedrice donteatfriedrice changed the title fix: newly added ai chat block index fix: ai chat block added later should with higher index Jul 30, 2024
@donteatfriedrice donteatfriedrice changed the title fix: ai chat block added later should with higher index fix: ai chat block added later should be with higher index Jul 30, 2024
@donteatfriedrice donteatfriedrice marked this pull request as ready for review July 30, 2024 11:02
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.60%. Comparing base (ede5760) to head (52a95af).

Files Patch % Lines
...ocksuite/presets/ai/_common/chat-actions-handle.ts 0.00% 3 Missing ⚠️
...suite/presets/ai/peek-view/chat-block-peek-view.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7660       +/-   ##
===========================================
- Coverage   56.55%   27.60%   -28.95%     
===========================================
  Files         949      741      -208     
  Lines       42328    18374    -23954     
  Branches     4909     3353     -1556     
===========================================
- Hits        23940     5073    -18867     
+ Misses      18029    12995     -5034     
+ Partials      359      306       -53     
Flag Coverage Δ
server-test ?
unittest 27.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 31, 2024

Merge activity

@donteatfriedrice donteatfriedrice force-pushed the 07-30-fix_newly_added_ai_chat_block_index branch from 29a2135 to 52a95af Compare July 31, 2024 03:16
@graphite-app graphite-app bot merged commit 52a95af into canary Jul 31, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 07-30-fix_newly_added_ai_chat_block_index branch July 31, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants