Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add track events for page option #7664

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jul 30, 2024

No description provided.

@JimmFly JimmFly marked this pull request as ready for review July 30, 2024 15:37
Copy link

nx-cloud bot commented Jul 30, 2024

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 26.79%. Comparing base (74025fc) to head (7edd788).

Files Patch % Lines
...d/core/src/components/page-list/operation-cell.tsx 0.00% 11 Missing ⚠️
...rc/modules/explorer/views/nodes/doc/operations.tsx 0.00% 3 Missing ⚠️
.../modules/explorer/views/nodes/collection/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           jimmfly/0730/track    #7664      +/-   ##
======================================================
- Coverage               26.80%   26.79%   -0.02%     
======================================================
  Files                     791      791              
  Lines                   19329    19343      +14     
  Branches                 3577     3578       +1     
======================================================
  Hits                     5182     5182              
- Misses                  13832    13846      +14     
  Partials                  315      315              
Flag Coverage Δ
unittest 26.79% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch from 5f30437 to 40a325d Compare August 5, 2024 10:41
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch from 40a325d to 8f65af3 Compare August 5, 2024 10:48
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch 2 times, most recently from 4f1407d to 27997b0 Compare August 5, 2024 12:36
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch from 27997b0 to 8fa7a24 Compare August 5, 2024 12:49
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch from 8fa7a24 to f15d0b5 Compare August 5, 2024 12:57
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch 2 times, most recently from 35eeb6f to d7d248d Compare August 6, 2024 10:27
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch from d7d248d to 137afe7 Compare August 6, 2024 15:22
@JimmFly JimmFly requested a review from forehalo August 6, 2024 15:23
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch from 137afe7 to 3f4dc5b Compare August 7, 2024 02:36
@JimmFly JimmFly force-pushed the jimmfly/0730/track_page_option branch 2 times, most recently from c24c38b to 6cd8838 Compare August 7, 2024 04:58
Copy link

graphite-app bot commented Aug 7, 2024

Merge activity

@forehalo forehalo force-pushed the jimmfly/0730/track_page_option branch from 6cd8838 to 7edd788 Compare August 7, 2024 05:53
Base automatically changed from jimmfly/0730/track to canary August 7, 2024 06:05
@graphite-app graphite-app bot merged commit 7edd788 into canary Aug 7, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0730/track_page_option branch August 7, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants