Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using width atom for syncing app headers position #7666

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 30, 2024

may use global state to replace these sidebar state atoms

fix AF-1109

Copy link
Collaborator Author

pengx17 commented Jul 30, 2024

Copy link

nx-cloud bot commented Jul 30, 2024

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 27.60%. Comparing base (812fdd2) to head (6b8f99c).

Files Patch % Lines
.../modules/app-tabs-header/views/app-tabs-header.tsx 5.26% 18 Missing ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                          @@
##           xp/07-30-fix_tab_label_overflow_style_when_there_is_only_one_tab    #7666      +/-   ##
====================================================================================================
- Coverage                                                             27.60%   27.60%   -0.01%     
====================================================================================================
  Files                                                                   741      741              
  Lines                                                                 18374    18383       +9     
  Branches                                                               3354     3358       +4     
====================================================================================================
+ Hits                                                                   5073     5075       +2     
- Misses                                                                12995    13002       +7     
  Partials                                                                306      306              
Flag Coverage Δ
unittest 27.60% <5.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 force-pushed the xp/07-30-fix_tab_label_overflow_style_when_there_is_only_one_tab branch from 01233b0 to 596ea69 Compare July 31, 2024 03:20
@pengx17 pengx17 force-pushed the xp/07-31-try_using_width_atom_for_syncing_app_headers_position branch 2 times, most recently from 45e961e to 2e8de7b Compare July 31, 2024 03:23
@pengx17 pengx17 marked this pull request as ready for review July 31, 2024 03:29
@pengx17 pengx17 changed the title try using width atom for syncing app headers position fix: using width atom for syncing app headers position Jul 31, 2024
Copy link

graphite-app bot commented Jul 31, 2024

Merge activity

may use global state to replace these sidebar state atoms

fix AF-1109
@pengx17 pengx17 force-pushed the xp/07-30-fix_tab_label_overflow_style_when_there_is_only_one_tab branch from 596ea69 to 812fdd2 Compare July 31, 2024 07:03
@pengx17 pengx17 force-pushed the xp/07-31-try_using_width_atom_for_syncing_app_headers_position branch from 2e8de7b to 6b8f99c Compare July 31, 2024 07:04
@pengx17 pengx17 changed the base branch from xp/07-30-fix_tab_label_overflow_style_when_there_is_only_one_tab to canary July 31, 2024 07:17
@graphite-app graphite-app bot merged commit 6b8f99c into canary Jul 31, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/07-31-try_using_width_atom_for_syncing_app_headers_position branch July 31, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants