Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): loading ui for favorite and organize #7700

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 2, 2024

No description provided.

Copy link

graphite-app bot commented Aug 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Aug 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Aug 2, 2024
@EYHN EYHN marked this pull request as ready for review August 2, 2024 04:32
Copy link

nx-cloud bot commented Aug 2, 2024

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 4.08163% with 47 lines in your changes missing coverage. Please review.

Project coverage is 26.52%. Comparing base (94c5eff) to head (e54be7d).

Files Patch % Lines
...ages/common/infra/src/modules/db/entities/table.ts 0.00% 15 Missing ⚠️
...ackages/common/infra/src/modules/db/services/db.ts 0.00% 15 Missing ⚠️
...ackages/common/infra/src/modules/db/entities/db.ts 0.00% 6 Missing ⚠️
...odules/explorer/views/sections/favorites/empty.tsx 0.00% 2 Missing ⚠️
...modules/explorer/views/sections/organize/empty.tsx 0.00% 2 Missing ⚠️
...ntend/core/src/modules/favorite/stores/favorite.ts 0.00% 2 Missing ⚠️
...odules/explorer/views/sections/favorites/index.tsx 0.00% 1 Missing ⚠️
...modules/explorer/views/sections/organize/index.tsx 0.00% 1 Missing ⚠️
...ore/src/modules/favorite/entities/favorite-list.ts 0.00% 1 Missing ⚠️
.../core/src/modules/organize/entities/folder-tree.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7700       +/-   ##
===========================================
- Coverage   55.42%   26.52%   -28.91%     
===========================================
  Files         998      792      -206     
  Lines       43334    19477    -23857     
  Branches     5171     3620     -1551     
===========================================
- Hits        24020     5166    -18854     
+ Misses      18955    14005     -4950     
+ Partials      359      306       -53     
Flag Coverage Δ
server-test ?
unittest 26.52% <4.08%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 2, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/feat/explorer-loading branch from 4e5d0ee to e54be7d Compare August 2, 2024 07:17
@graphite-app graphite-app bot merged commit e54be7d into canary Aug 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/explorer-loading branch August 2, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants