Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): new tab/split view entries #7708

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 2, 2024

fix AF-1146

Copy link

graphite-app bot commented Aug 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Aug 2, 2024

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 29.62963% with 19 lines in your changes missing coverage. Please review.

Project coverage is 26.52%. Comparing base (bd31c83) to head (51ca765).

Files Patch % Lines
...ages/frontend/core/src/modules/navigation/utils.ts 66.66% 1 Missing and 3 partials ⚠️
...les/explorer/views/nodes/collection/operations.tsx 0.00% 3 Missing ⚠️
...rc/modules/explorer/views/nodes/doc/operations.tsx 0.00% 3 Missing ⚠️
...rc/modules/explorer/views/nodes/tag/operations.tsx 0.00% 3 Missing ⚠️
...d/core/src/components/page-list/operation-cell.tsx 0.00% 2 Missing ⚠️
...omponents/page-list/view/collection-operations.tsx 0.00% 2 Missing ⚠️
...s/workbench/services/desktop-state-synchronizer.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7708       +/-   ##
===========================================
- Coverage   55.35%   26.52%   -28.83%     
===========================================
  Files        1005      797      -208     
  Lines       43420    19544    -23876     
  Branches     5190     3637     -1553     
===========================================
- Hits        24035     5184    -18851     
+ Misses      19024    14051     -4973     
+ Partials      361      309       -52     
Flag Coverage Δ
server-test ?
unittest 26.52% <29.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from beac7ec to 44309f3 Compare August 2, 2024 08:49
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch from 113db6b to c045c4a Compare August 2, 2024 08:49
@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from 44309f3 to 5501913 Compare August 2, 2024 08:55
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch from c045c4a to fde4af7 Compare August 2, 2024 08:55
@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from 5501913 to 6f11fe9 Compare August 2, 2024 09:15
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch 2 times, most recently from 6ead504 to 36fe8b5 Compare August 2, 2024 10:22
@github-actions github-actions bot added the mod:i18n Related to i18n label Aug 2, 2024
@pengx17 pengx17 marked this pull request as ready for review August 2, 2024 10:25
@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from 6f11fe9 to 123438b Compare August 2, 2024 10:27
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch 2 times, most recently from b8674d1 to db415c4 Compare August 2, 2024 10:43
@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from 123438b to ae3a37a Compare August 2, 2024 11:00
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch from db415c4 to 718eb49 Compare August 2, 2024 11:00
@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from ae3a37a to 7ae6d3e Compare August 5, 2024 02:47
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch from 718eb49 to e069c79 Compare August 5, 2024 02:47
@pengx17 pengx17 force-pushed the 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs branch from 7ae6d3e to c0c5c83 Compare August 5, 2024 03:14
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch from e069c79 to 3332f23 Compare August 5, 2024 03:17
@github-actions github-actions bot added the test Related to test cases label Aug 5, 2024
Copy link
Collaborator Author

pengx17 commented Aug 5, 2024

Merge activity

  • Aug 4, 11:18 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Aug 5, 1:37 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Aug 5, 1:48 AM EDT: pengx17 merged this pull request with the Graphite merge queue.

@pengx17 pengx17 changed the base branch from 08-02-fix_electron_should_activate_the_target_tab_when_closing_other_tabs to canary August 5, 2024 03:18
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch 4 times, most recently from 7e7ae29 to c6b2630 Compare August 5, 2024 05:25
@pengx17 pengx17 force-pushed the 08-02-feat_electron_new_tab_split_view_entries branch from c6b2630 to 51ca765 Compare August 5, 2024 05:37
@graphite-app graphite-app bot merged commit 51ca765 into canary Aug 5, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-02-feat_electron_new_tab_split_view_entries branch August 5, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:i18n Related to i18n test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants